might also fix #254

This seems to fix #254

I think better thing to do here is to remove connectMcpServer from the useHook dependency. It was added as part of https://github.com/modelcontextprotocol/inspector/pull/218/files to address ESlint warnings .

@pulkitsharma07 I was eyeing the same, but I'm also trying to understand if there was something else that exposed the issue since I believe we tested the oauth flow with that PR before merging. I am putting together a few test scenarios using a couple of the snippets shared for reproducing these issues that could help ensure that we're not just playing whack a mole here.

I'm not a FE engineer by trade so take these comments with a grain of salt:

• Short-term: I think moving the reconnection logic to within the useConnection hook would make things easier to manage.
• Longer-term: Some sort of global state management might be in order - right now we have components communicating state over URL query params, session storage, and lots and lots of independent useState bits. It makes the data flow pretty difficult to follow (for me at least) and increases the # of rerendering bugs. Last I touched global state management was in... 2019? when Redux was king so I don't have strong opinions on what a solution would look like here, but even a top level useReducer might go a long way.

Created an alternative approach to solving the immediate problem here: #259

@max-stytch your suggestions sound like good options. I'll create an issue to make sure we have a place to track those medium-term to longer-term suggestions. As someone who is also not a FE engineer by trade it would be great to get more perspective on the best options here.

Created an alternative approach to solving the immediate problem here: #259

@max-stytch your suggestions sound like good options. I'll create an issue to make sure we have a place to track those medium-term to longer-term suggestions. As someone who is also not a FE engineer by trade it would be great to get more perspective on the best options here.

The hooks rule that any function used in a hook should be passed in as a dep is the rock. The fact that each rerender recreates the function and runs it again is the hard place. The fix here is that we have a durable flag (the ref) that can tell us whether the thread of execution has passed through this hook in the past, allowing us to only execute it once.